Fix history rollback command does not meet the expected result #2042
Conversation
chenhaixing123
force-pushed
the
master
branch
from
6203c68
to
e3a37a1
Compare
| "Obsolete": "Obsoleted", | ||
| "Reason Change": "Reason Change", | ||
| "Obsolete": None, | ||
| "Reason Change": None, |
There was a problem hiding this comment.
Hmm, I don't think this is right. It breaks the workflow when rolling back group and environment upgrades while reviewing test results. While the actual action appears to be executed, the group and environment reasons are not recorded in the history database. We need to rather investigate the root cause of the reproducer outlined in the issue.
| @@ -536,13 +536,18 @@ def run(self): | |||
|
|
|||
| for pkg_data in self._rpms: | |||
| try: | |||
| action = pkg_data["action"] | |||
| if action is None: | |||
| continue | |||
There was a problem hiding this comment.
This is also not correct, we would miss logging the unexpected state transitions.
|
@chenhaixing123 Thanks for submitting this one, it seems that it pointed me to the exact point of the problem here. I've prepared a follow-up PR for that. Let's wait for the tests and we can merge that one instead, what do you think? |
|
Thank you for reviewing the PR. |
I'll probably need to rework the new PR. The root cause is probably somewhere else, more likely in the library code. I'll send the update with the findings in the PR. For now, it seems to me "more correct" to do nothing in such cases. |
|
I've prepared another PR to fix the issue already in the library code: |
= changelog =
msg: Fix history rollback command does not meet the expected result
type: bugfix
resolves: #2031
related: #1689