Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for group upgrade rollback (RhBug:2016070) #1844

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

jan-kolarik
Copy link
Member

Allow doing a rollback after group upgrade action.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2016070.

@pep8speaks
Copy link

pep8speaks commented Aug 23, 2022

Hello @jan-kolarik! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-25 06:06:57 UTC

@jan-kolarik jan-kolarik force-pushed the jkolarik/group-upgrade-rollback branch from 6b9fcc7 to 7c90fe3 Compare August 25, 2022 06:06
@jan-kolarik
Copy link
Member Author

I was thinking about adding some additional notes into dnf history rollback man pages, but I don't think this is adding any more behavior than what it's described there. Just fixing the state rollback to work with groups and environments.

For me the interesting finding was that when defining excluded packages when installing/upgrading groups then this configuration is remembered until the group is installed/upgraded again with the install command. But this is not related to the changes of this commit.

@jan-kolarik jan-kolarik marked this pull request as ready for review August 26, 2022 13:28
@lukash lukash merged commit b623eed into master Aug 30, 2022
@lukash lukash deleted the jkolarik/group-upgrade-rollback branch August 30, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants