Add support for rollback of group upgrade rollback (RhBug:2016070) #1852
Conversation
|
It took me some time to figure out why should "Upgrade" and "Upgraded" (and "Downgrade" and "Downgraded") be treated the same for groups and environments. For packages, it's different, because there are the two versions and you want to erase one and install the other, but groups don't have versions, so this distinction doesn't make sense. It's always saved as "Upgrade" and "Downgrade", but it can be switched to "Downgraded" and "Upgraded" when making reverse transaction or it can stay as "Upgrade" or "Downgrade" when redoing the same transaction, so the action can be in both forms. It's not nice, but I think making the change here is the best option. However, can you add a comment either to the code or to the commit message explaining what's going on? |
= changelog = type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2016070
jan-kolarik
force-pushed
the
jkolarik/group-upgrade-rollback-2
branch
from
b022428
to
c377f4f
Compare
|
@pkratoch Thanks for the review. I've added comments into the code, hope it is more clear now. |
Support for group upgrade rollback was already added in #1844.
This fix enables also undoing the rollback transaction.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2016070.