Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POT files are never updated causing dropping newly translated messages #1744

Closed
ppisar opened this issue Oct 1, 2024 · 0 comments · Fixed by #1745
Closed

POT files are never updated causing dropping newly translated messages #1744

ppisar opened this issue Oct 1, 2024 · 0 comments · Fixed by #1745
Assignees
@ppisar
Labels
Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@ppisar
Copy link
Contributor

ppisar commented Oct 1, 2024

As pointed in #1736 (comment) comment, installed DNF5 is missing newly added messages for a translation. The cause is that we never update POT files here in DNF5 repository. As a result msgmerge run later during a build will merge the updated po files against the out-dated pot files, resulting in removing the messages from the translation catalogs.

We either need to amend .github/actions/weblate-pull-translations/action.yml script to copy the POT files from dnf5-l10n repository, or stop calling msgmerge at built time.

The latter option would simplify the process. But because we deliver the POT in source archive and code repository, I'd adopt the former option.
@ppisar ppisar mentioned this issue Oct 1, 2024
Open
@ppisar ppisar added Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take labels Oct 1, 2024
@ppisar ppisar self-assigned this Oct 1, 2024
ppisar added a commit to ppisar/dnf5 that referenced this issue Oct 1, 2024
@ppisar
i18n: Update translation templates from Weblate
c323c42 
Translation cataloges (*.pot) files were updated last time in year
2023. As a result msgmerge run during building DNF5 removed all newly
added translated messages from message cataloges because the new
messages were missing from the template files.

This patch fixes it by copying the templates together with messages
catalogs from Weblate on every DNF5 release.

Resolves: rpm-software-management#1744
ppisar added a commit to ppisar/dnf5 that referenced this issue Oct 1, 2024
@ppisar
i18n: Update translation templates from Weblate
e55eec2 
Translation template (*.pot) files were updated last time in year
2023. As a result msgmerge run during building DNF5 removed all newly
added translated messages from message cataloges because the new
messages were missing from the template files.

This patch fixes it by copying the templates together with messages
catalogs from Weblate on every DNF5 release.

Resolves: rpm-software-management#1744
@ppisar ppisar mentioned this issue Oct 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 1, 2024
@ppisar @evan-goode
i18n: Update translation templates from Weblate
126a07a 
Translation template (*.pot) files were updated last time in year
2023. As a result msgmerge run during building DNF5 removed all newly
added translated messages from message cataloges because the new
messages were missing from the template files.

This patch fixes it by copying the templates together with messages
catalogs from Weblate on every DNF5 release.

Resolves: #1744
@bc-lee bc-lee mentioned this issue Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisar ppisar

Labels
Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i18n: Update translation templates from Weblate ppisar/dnf5
1 participant
@ppisar