Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Update translation templates from Weblate #1745

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Oct 1, 2024

Translation template (*.pot) files were updated last time in year
2023. As a result msgmerge run during building DNF5 removed all newly added translated messages from message cataloges because the new messages were missing from the template files.

This patch fixes it by copying the templates together with messages catalogs from Weblate on every DNF5 release.

Resolves: #1744

Translation template (*.pot) files were updated last time in year
2023. As a result msgmerge run during building DNF5 removed all newly
added translated messages from message cataloges because the new
messages were missing from the template files.

This patch fixes it by copying the templates together with messages
catalogs from Weblate on every DNF5 release.

Resolves: rpm-software-management#1744
@ppisar
Copy link
Contributor Author

ppisar commented Oct 1, 2024

@evan-goode, you do releases recently. Could you review this pull request?

Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@evan-goode evan-goode added this pull request to the merge queue Oct 1, 2024
Merged via the queue into rpm-software-management:main with commit 126a07a Oct 1, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POT files are never updated causing dropping newly translated messages
2 participants