-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change of default for allow_vendor_change #623
Conversation
67f9055
to
3edbed3
Compare
doc/changes.rst
Outdated
@@ -143,6 +143,12 @@ Upgrade command | |||
Changes of configuration: | |||
========================= | |||
|
|||
Defauilt of `allow_vendor_change` configuration option changed to `false` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo - defauilt -> default
he new default (false) value improves behavior for users that use third party repository (Copr). If they install a package from alternative provider, DNF will continue to consume updates from the same vendor. Additionally it enables to ship alternative streams using a different vendor.
Co-authored-by: Marek Blaha <[email protected]>
It looks like tests failed on gpg import
|
Hm, let me investigate the test results. I have done some changes in this part of code recently... |
Btw, are those changes (adding vendor) in test *.spec files needed? It looks like they are not used anywhere and tests are passing even without them. |
I am unable to reproduce the test issue locally. |
It looks like the gpg tests are a bit flaky... I'll re-run them, just to see whether the issue is reproducible. |
The changes of unit tests are required because we have in tests newly build rpms with installed rpms injected by test case. In some cases new rpms have vendor set according to detected macros on your system. |
I've seen this gpg test failure before (although on a different scenarion). There apparently is some instability in gpg tests, but currently I don't have a clue what's wrong. |
Requires: #621