Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change of default for allow_vendor_change #623

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Change of default for allow_vendor_change #623

merged 2 commits into from
Jun 26, 2023

Conversation

j-mracek
Copy link
Contributor

Requires: #621

@j-mracek j-mracek force-pushed the vendor branch 5 times, most recently from 67f9055 to 3edbed3 Compare June 26, 2023 09:26
m-blaha
m-blaha reviewed Jun 26, 2023
View reviewed changes
doc/changes.rst Outdated
@@ -143,6 +143,12 @@ Upgrade command
Changes of configuration:
=========================

Defauilt of `allow_vendor_change` configuration option changed to `false`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo - defauilt -> default

doc/changes.rst Outdated Show resolved Hide resolved
j-mracek and others added 2 commits June 26, 2023 12:25
@j-mracek
Modify default value for allow_vendor_change configuration
bf4fe03 
he new default (false) value improves behavior for users that use third
party repository (Copr). If they install a package from alternative
provider, DNF will continue to consume updates from the same vendor.
Additionally it enables to ship alternative streams using a different
vendor.
@j-mracek @m-blaha
Improve the documentation
eac9653 
Co-authored-by: Marek Blaha <[email protected]>
@j-mracek
Copy link
Contributor Author

It looks like tests failed on gpg import

       Importing PGP key 0x4429F6AC:
       Userid     : "dnf-ci-gpg-subkey"
       Fingerprint: A77F516D310F680AFBFFF814DEB7ECAB4429F6AC
       From       : file:///opt/ci/dnf-behave-tests/fixtures/gpgkeys/keys/dnf-ci-gpg-subkey/dnf-ci-gpg-subkey-public
      [org.rpm.dnf.v0.rpm.Rpm.TransactionError] rpm transaction failed with code 6.

@m-blaha
Copy link
Member

m-blaha commented Jun 26, 2023

Hm, let me investigate the test results. I have done some changes in this part of code recently...

@m-blaha
Copy link
Member

m-blaha commented Jun 26, 2023

Btw, are those changes (adding vendor) in test *.spec files needed? It looks like they are not used anywhere and tests are passing even without them.

@j-mracek
Copy link
Contributor Author

I am unable to reproduce the test issue locally.

@m-blaha
Copy link
Member

m-blaha commented Jun 26, 2023

It looks like the gpg tests are a bit flaky... I'll re-run them, just to see whether the issue is reproducible.

@j-mracek
Copy link
Contributor Author

The changes of unit tests are required because we have in tests newly build rpms with installed rpms injected by test case. In some cases new rpms have vendor set according to detected macros on your system.

@m-blaha m-blaha added this pull request to the merge queue Jun 26, 2023
Merged via the queue into rpm-software-management:main with commit 1b72f42 Jun 26, 2023
@m-blaha
Copy link
Member

m-blaha commented Jun 26, 2023

I've seen this gpg test failure before (although on a different scenarion). There apparently is some instability in gpg tests, but currently I don't have a clue what's wrong.

@kontura kontura mentioned this pull request Jul 12, 2023
Open
@jan-kolarik jan-kolarik mentioned this pull request Jul 14, 2023
Closed
@evan-goode evan-goode mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-blaha m-blaha m-blaha left review comments

Assignees
No one assigned
Labels
None yet
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mracek @m-blaha