Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NegatedIsNil memory leak #1094

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

msutkowski
Copy link
Contributor

@msutkowski msutkowski commented Nov 18, 2023

Fixes #1056.

Prior to this, this example test would raise 9 issues:

test "regression test for issue list duplication" do
  """
  defmodule CredoSampleModule do
    def hello(a) when not is_nil(a), do: a
    def foo1(x) when is_integer(x), do: x
    def foo2(x) when is_integer(x), do: x
    def foo3(x) when is_integer(x), do: x
  end
  """
  |> to_source_file()
  |> run_check(@described_check)
  |> assert_issue()
end

@rrrene rrrene merged commit 3ef7c5a into rrrene:master Nov 19, 2023
12 of 13 checks passed
@rrrene
Copy link
Owner

rrrene commented Nov 19, 2023

@msutkowski Thx!

@msutkowski msutkowski deleted the ms/fix-negatedisnil branch November 20, 2023 14:53
@pdm-jd
Copy link

pdm-jd commented Nov 22, 2023

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NegatedIsNil check can consume all available memory
3 participants