fix: negated_is_nil when nested in guards #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a custom guard uses `not is_nil(foo)`, the number of issues reported by `Credo.Check.Refactor.NegatedIsNil` increases significantly. For instance, this would report three violations. ```elixir defguard custom_guard(value) when not is_nil(value) def bar(foo, baz) when not is_nil(foo) and custom_guard(baz) do end ``` This change ensures only a maximum of one issue per part of the guard will be reported. See the added tests for examples.
|
Oof, #1094 beat me too it. |
|
@pdm-jd Still glad you took the time 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a custom guard uses
not is_nil(foo), the number of issues reported byCredo.Check.Refactor.NegatedIsNilincreases significantly.For instance, this would report three violations.
This change ensures only a maximum of one issue per part of the guard will be reported. See the added tests for examples.