Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laue dials preprint blogpost #24

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Conversation

PrinceWalnut
Copy link
Contributor

Blogpost about the new Laue-DIALS preprint on bioRxiv, including a few specifics of the package and figure illustrations about use + pink-beam crystallography.

@PrinceWalnut
Copy link
Contributor Author

@dennisbrookner could you test this works in Jekyll just fine and will display appropriately? I used Kevin's suggestions for displaying media but want to be sure

Copy link
Member

@kmdalton kmdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i made some stylistic suggestions.

_posts/2024-08-07-laue-dials-preprint.md Outdated Show resolved Hide resolved
_posts/2024-08-07-laue-dials-preprint.md Outdated Show resolved Hide resolved
_posts/2024-08-07-laue-dials-preprint.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dennisbrookner dennisbrookner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I just made the following minor changes:

  • reformat the blog post to use the .blog-XXX CSS classes
  • create the new CSS class .blog-image-narrow which has 50% width, rather than 80% width. I think this will continue to be useful going forward
  • remove the unnecessary usemathjax from the front matter

@PrinceWalnut
Copy link
Contributor Author

Okay, implemented Kevin's suggestions for the phrasing. @dennisbrookner I'll leave it to you for a final approval/merge if everything formats correctly.

@dennisbrookner dennisbrookner merged commit 11a1e2c into main Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants