Added signer authorization generation option that uses standard Ethereum app #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
italo-sampaio
commented
Jul 1, 2022
italo-sampaio
commented
- Added new "eth" option to signap.py
- Added DongleEth class to handle communication with the Ethereum app
- Added unit tests for DongleEth class
- Added unit tests for the new signapp.py "eth" operation
amendelzon
requested changes
Jul 4, 2022
…app to generate signer authorization - Added new "eth" option to signap - Added DongleEth class to handle communication with the Ethereum app - Added unit tests for DongleEth class - Added unit tests for the new signapp "eth" operation
…ptions of signapp.py
- Added new option to to_binary() method that allows encoding to little-endian or big-endian - Using existing classes to parse the eth path on dongle_eth
italo-sampaio
force-pushed
the
enhancement/59-enhance-signapp-with-ethereum-app-signing-capabilities
branch
from
14edda1
to
ae0b400
Compare
amendelzon
reviewed
Jul 4, 2022
amendelzon
reviewed
Jul 4, 2022
amendelzon
previously approved these changes
Jul 4, 2022
- Added meaningful error messages to dongle_eth.py - Added new -b/--pubkey flag to signapp.py to retrieve public key from eth app - Added new unit tests for specific exceptions from songle_eth.py - Some names changed for clarity
amendelzon
reviewed
Jul 5, 2022
amendelzon
reviewed
Jul 5, 2022
italo-sampaio
deleted the
enhancement/59-enhance-signapp-with-ethereum-app-signing-capabilities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.