Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added signer authorization generation option that uses standard Ethereum app #65

Merged
merged 10 commits into from
Jul 5, 2022
Merged

Added signer authorization generation option that uses standard Ethereum app #65

merged 10 commits into from
Jul 5, 2022

Commits on Jul 4, 2022

  1. Added new option to signapp.py that allows using a standard Ethereum … 

    …app to generate signer authorization

- Added new "eth" option to signap
- Added DongleEth class to handle communication with the Ethereum app
- Added unit tests for DongleEth class
- Added unit tests for the new signapp "eth" operation
    @italo-sampaio
    italo-sampaio committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    5a26abd View commit details
    Browse the repository at this point in the history

  2. Removed some magic numbers

    @italo-sampaio
    italo-sampaio committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    e495fae View commit details
    Browse the repository at this point in the history

  3. Changed casing of dongle_eth.py to underscore_casing

    @italo-sampaio
    italo-sampaio committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    00eb55c View commit details
    Browse the repository at this point in the history

  4. Using same 'path' command line argument for both 'ledger' and 'eth' o… 

    …ptions of signapp.py
    @italo-sampaio
    italo-sampaio committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    8decfb3 View commit details
    Browse the repository at this point in the history

  5. Using BIP32Path to parse eth parse 

    - Added new option to to_binary() method that allows encoding to little-endian or big-endian
- Using existing classes to parse the eth path on dongle_eth
    @italo-sampaio
    italo-sampaio committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    906191f View commit details
    Browse the repository at this point in the history

  6. Added validation to sign command if message is too big

    @italo-sampaio
    italo-sampaio committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    ae0b400 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Changes after code review 

    - Added meaningful error messages to dongle_eth.py
- Added new -b/--pubkey flag to signapp.py to retrieve public key from eth app
- Added new unit tests for specific exceptions from songle_eth.py
- Some names changed for clarity
    @italo-sampaio
    italo-sampaio committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    4f459c0 View commit details
    Browse the repository at this point in the history

  2. More fixes after code review

    @italo-sampaio
    italo-sampaio committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    d6ce03b View commit details
    Browse the repository at this point in the history

  3. DongleEthError refactoring

    @italo-sampaio
    italo-sampaio committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    c85783a View commit details
    Browse the repository at this point in the history

  4. Changed error message

    @italo-sampaio
    italo-sampaio committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    0b0815a View commit details
    Browse the repository at this point in the history