Explicitly support kwargs in shared example groups #2711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the introduction of Ruby 2.7, positional and keyword argument separation is required, otherwise it warns: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/ This patch allows RSpec to use kwargs explicitly with shared context, as in: ```ruby RSpec.shared_examples "shared context" do |foo:| ```
|
Oh wow I didn't realize the support matrix went back that far. I'll take another pass at this. |
|
I suppose it won't be possible to get rid of those warnings and support older Rubies at the same time without |
|
Yeah, I've seen the |
|
Hi @kddeisz I've closed this for now in favour of #2716, however, I'd prefer your version when we work on RSpec 4 that drops support for older Rubies. |
|
No worries! Let me know when you’re ready to do that I’d love to contribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the introduction of Ruby 2.7, positional and keyword argument separation is required, otherwise it warns:
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
This patch allows RSpec to use kwargs explicitly with shared context, as in: