Explicitly support keyword arguments in shared context on 2.7.0 #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
explictly-support-kwargs-shared-context
branch
from
b3e0bce
to
8cac9c3
Compare
pirj
reviewed
Apr 4, 2020
JonRowe
force-pushed
the
explictly-support-kwargs-shared-context
branch
2 times, most recently
from
facb7e7
to
c38a933
Compare
JonRowe
force-pushed
the
explictly-support-kwargs-shared-context
branch
from
c38a933
to
a0da03c
Compare
This was referenced Apr 8, 2020
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…red-context Explicitly support keyword arguments in shared context on 2.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative #2711 that uses the method signature from rspec-support to conditionally apply keyword arguments on supporting rubies, it is 1.8.7 compatible.
This is a shorter change, but not a better one, it should be replaced by #2711 when we work on RSpec 4.