Differ tests no longer use Differ to report diff expectation #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok I like this approach so this isn't a block, but I'm wondering if "correctly" diffed is the right name for the matcher, |
For example, previously we would write our differ_spec expectations as
actual = differ.diff(str1, str2)
expect(actual).to eq(expected)
Which had the suprising (but expected) result of failure diffing changing the string
actual = differ.diff(str1, str2)
actual != expected &&
RSpec::Expectations.fail_with(message, actual, expected)
RSpec::Expectations.fail_with calls differ.diff(actual, expected)
where differ is **RSpec::Support::Differ.new**(
:object_preparer => lambda { |object| RSpec::Matchers::Composable.surface_descriptions_in(object) },
:color => RSpec::Matchers.configuration.color?
)
So, all these differ_spec.rb tests where we say expect(str1).to eq(str2)
will run through the differ twice on failure.
Rather than test them as expect(str1 == str2).to eq(true), use
the #be_correctly_diffed matcher.
We're not testing encoding because strings created in differ_spec.rb have a default
encoding of UTF-8 in all cases, but string created in the differ.rb may be
US-ASCII in MRI prior to 2.0 else UTF-8.
https://github.com/ruby/ruby/blob/aacc35e144/encoding.c#L1741
bf4
force-pushed
the
dont_diff_differ_failures
branch
from
f0f25f0
to
7700d2e
Compare
|
@JonRowe renamed. There is duplication with the matcher in encoded_string_spec but I figure that can be a later refactor if desired. |
JonRowe
added a commit
that referenced
this pull request
Feb 8, 2015
Differ tests no longer use Differ to report diff expectation
|
Thanks, would you like to tackle the duplication? |
|
Sure. What do you think about putting it in |
|
Sure |
|
ref #176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, previously we would write our differ_spec expectations as
Which had the suprising (but expected) result
of failure diffing changing the string
RSpec::Expectations.fail_withcallsdiffer.diff(actual, expected)where differ is
So, all these differ_spec.rb tests where we say
expect(str1).to eq(str2)willrun through the differ twice on failure.
Rather than test them as
expect(str1 == str2).to eq(true), use the#be_correctly_diffedmatcher.We're not testing encoding because strings created in differ_spec.rb have a
default encoding of UTF-8 in all cases, but string created in the differ.rb
may be US-ASCII in MRI prior to 2.0 else UTF-8.
https://github.com/ruby/ruby/blob/aacc35e144/encoding.c#L1741
Refs: