Unify be_identical_string/be_diffed_as in spec/string_matcher.rb #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # check for string encoding. | ||
| def expected_encoding? | ||
| if defined?(@expect_same_encoding) && @expect_same_encoding | ||
| actual.encoding == expected.encoding |
There was a problem hiding this comment.
I'm really not sure how to get the best semantics from the matchers and also the least hacky implementation of the matcher. I'm not married to this implementation, but I liked the semantics of be_identical_string(str).with_same_encoding better than adding a new be_identical_encoded_string that is called from be_identical_string.
There was a problem hiding this comment.
I just missed the encoding check above
Changed meaning of be_identical_string not to include an encoding comparison. Encoding comparison is now only turned on by chaining 'with_same_encoding'. This leaves open the possibility of chaining 'with_encoding(enc)', but there's currently not need for that.
bf4
force-pushed
the
factor_out_string_matcher
branch
from
8b9d490
to
92c3e0e
Compare
|
forgot to require "rspec/matchers" at the top of the file. amended and force pushed. |
|
LGTM |
JonRowe
added a commit
that referenced
this pull request
Feb 9, 2015
Unify be_identical_string/be_diffed_as in spec/string_matcher.rb
|
Thanks @bf4 :) |
|
Wow, that was quite a weekend. Thanks @JonRowe @myronmarston |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed meaning of be_identical_string not to include an encoding comparison.
Encoding comparison is now only turned on by chaining
'with_same_encoding'.
This leaves open the possibility of chaining 'with_encoding(enc)', but there's
currently not need for that.