Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tagQuery()$matches(fn) #351

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement tagQuery()$matches(fn) #351

wants to merge 9 commits into from
+109 −11

Conversation

schloerke
Copy link
Collaborator

Fixes #350

(html <- tagList(div(), span()))
#> <div></div>
#> <span></span>
tagQ <- tagQuery(html)
tagQ$matches("span")
#> [1] FALSE TRUE
tagQ$matches(function(el, i) { el$name == "span" })
#> [1] FALSE TRUE

schloerke and others added 5 commits November 1, 2022 14:49
@schloerke
If the returned value is not isTRUE(), then return FALSE
2e0b6ba
@schloerke
Add news entry
d5701ac
@schloerke
Merge branch 'main' into tag_query_matches
f461c70 
* main:
  CSS selection rules should include hyphens and underscores (#354)
  `document()` (#360)
  Start new version
  v0.5.4 release candidate (#357)
  Fix bindFillRole() documentation example
  roxygenize
  Fix outdated news
@cpsievert
Merge branch 'main' into tag_query_matches
111ee2c
@cpsievert
Put NEWS item in the right spot
895d34b
cpsievert
cpsievert reviewed Apr 5, 2023
View reviewed changes
R/tag_query.R Outdated Show resolved Hide resolved
@cpsievert cpsievert mentioned this pull request Apr 5, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert left review comments

@jcheng5 jcheng5 Awaiting requested review from jcheng5

@gadenbuie gadenbuie Awaiting requested review from gadenbuie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tagQuery() $matches(cssSelector) functionality
2 participants
@schloerke @cpsievert