Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #73] The Minitest department works on _test.rb by default #74

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

koic
Copy link
Member

@koic koic commented Apr 10, 2020

Fixes #73.

This PR changes the Minitest department works on file names end with _test.rb by default.

RuboCop Minitest only targets files in test directory by default until v0.8.1.

Minitest:
  Enabled: true
  Include:
    - '**/test/**/*'

https://github.com/rubocop-hq/rubocop-minitest/blob/v0.8.1/config/default.yml

But test files may be located in a directory other than test directory.
This PR adds files that end of filename is _test.rb to be considered test files.

This behavior is similar to how RuboCop RSpec works on _spec.rb.
https://github.com/rubocop-hq/rubocop-rspec/blob/v1.38.1/config/default.yml#L5


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#73.

This PR changes the Minitest department works on file names end with
`_test.rb` by default.

RuboCop Minitest only targets files in `test` directory by default until v0.8.1.

```yaml
Minitest:
  Enabled: true
  Include:
    - '**/test/**/*'
```

https://github.com/rubocop-hq/rubocop-minitest/blob/v0.8.1/config/default.yml

But test files may be located in a directory other than `test` directory.
This PR adds files that end of filename is `_test.rb` to be considered test files.

This behavior is similar to how RuboCop RSpec works on `_spec.rb`.
https://github.com/rubocop-hq/rubocop-rspec/blob/v1.38.1/config/default.yml#L5
@koic koic merged commit 16b29db into rubocop:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto-correct works other directories like acceptance
1 participant