New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #73] The Minitest department works on `_test.rb` by default #74

Merged

koic merged 1 commit into rubocop:master from koic:work_on_file_names_end_with_test_rb

Apr 12, 2020

Commits on Apr 10, 2020

[Fix rubocop#73 ] The Minitest department works on _test.rb by default

Fixes rubocop#73.

This PR changes the Minitest department works on file names end with
`_test.rb` by default.

RuboCop Minitest only targets files in `test` directory by default until v0.8.1.

```yaml
Minitest:
  Enabled: true
  Include:
    - '**/test/**/*'
```

https://github.com/rubocop-hq/rubocop-minitest/blob/v0.8.1/config/default.yml

But test files may be located in a directory other than `test` directory.
This PR adds files that end of filename is `_test.rb` to be considered test files.

This behavior is similar to how RuboCop RSpec works on `_spec.rb`.
https://github.com/rubocop-hq/rubocop-rspec/blob/v1.38.1/config/default.yml#L5

koic committed Apr 10, 2020