Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run each spec file in a process to detect missing requires #980

Merged

Conversation

eregon
Copy link
Collaborator

@eregon eregon commented Jan 8, 2023

On top of #982

Notes:
I didn't find a builtin RSpec way to run each spec in a separate process. Probably we make our own rake task for that.
Locally, can use https://stackoverflow.com/questions/39902641/run-each-rspec-spec-file-individually or for f in spec/**/*_spec.rb; do; bundle exec rspec $f || break; done

TODO:

  • Audit usages of defined? and const_defined? and on_jruby?
  • Add test for require 'concurrent' and require 'concurrent-edge'
  • Add test for require any file under lib?
  • Update README

@eregon eregon force-pushed the missing-requires-and-isolated-specs branch from 6e457ed to 22f9003 Compare January 11, 2023 21:12
@eregon eregon force-pushed the missing-requires-and-isolated-specs branch 9 times, most recently from f748148 to bc0f369 Compare January 12, 2023 19:37
@eregon eregon force-pushed the missing-requires-and-isolated-specs branch from bc0f369 to 63de078 Compare January 12, 2023 20:57
@eregon eregon force-pushed the missing-requires-and-isolated-specs branch from 63de078 to 1fa9c17 Compare January 21, 2023 12:44
@eregon eregon marked this pull request as ready for review January 21, 2023 12:52
@eregon eregon merged commit d867c17 into ruby-concurrency:master Jan 21, 2023
@eregon eregon deleted the missing-requires-and-isolated-specs branch January 21, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Officially support requiring subparts of concurrent-ruby, e.g., require 'concurrent/map'
1 participant