Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Add ostruct as a Dependency in net-ldap #431

Closed
Ivanov-Anton opened this issue Oct 26, 2024 · 0 comments · Fixed by #432
Closed

Request to Add ostruct as a Dependency in net-ldap #431

Ivanov-Anton opened this issue Oct 26, 2024 · 0 comments · Fixed by #432

Comments

@Ivanov-Anton
Copy link
Contributor

Background:

With the release of Ruby 3.3.5, users are now receiving warnings when using libraries that utilize ostruct without explicitly declaring it as a dependency in their gemspec. This change highlights the need for better clarity on dependencies and may lead to confusion among users regarding the operational aspects of the net-ldap gem.

The current version of net-ldap (0.19.0) does not include ostruct in its gemspec file, which can cause warning messages when used in Ruby environments upgraded to version 3.3.5 or later.

Proposed Change:

I recommend reaching out to the maintainers of net-ldap to request that they add ostruct as a dependency in the gemspec. This addition would help prevent warnings for users while ensuring clear communication regarding the required components of the library.

Example Implementation:

In the net-ldap.gemspec file, adding the following line would suffice:

s.add_dependency("ostruct")
Ivanov-Anton added a commit to Ivanov-Anton/ruby-net-ldap that referenced this issue Oct 26, 2024
This commit adds `ostruct` as an explicit dependency
in the net-ldap gemspec.

With the release of Ruby 3.3.5 and later versions,
users of net-ldap may encounter warnings related
to the use of `ostruct` if it is not declared as
a dependency. By including `ostruct`, we aim to
enhance clarity regarding the gem's requirements
and prevent any runtime issues related to missing
dependencies.
HarlemSquirrel added a commit to Ivanov-Anton/ruby-net-ldap that referenced this issue Oct 29, 2024
HarlemSquirrel added a commit that referenced this issue Oct 29, 2024
#431, Add `ostruct` as a dependency to the gemspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant