Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#431, Add ostruct as a dependency to the gemspec #432

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Ivanov-Anton
Copy link
Contributor

Description

This commit adds ostruct as an explicit dependency in the net-ldap gemspec.

With the release of Ruby 3.3.5 and later versions, users of net-ldap may encounter warnings related to the use of ostruct if it is not declared as a dependency. By including ostruct, we aim to enhance clarity regarding the gem's requirements and prevent any runtime issues related to missing dependencies.

Related links

closes #431

This commit adds `ostruct` as an explicit dependency
in the net-ldap gemspec.

With the release of Ruby 3.3.5 and later versions,
users of net-ldap may encounter warnings related
to the use of `ostruct` if it is not declared as
a dependency. By including `ostruct`, we aim to
enhance clarity regarding the gem's requirements
and prevent any runtime issues related to missing
dependencies.
@Ivanov-Anton
Copy link
Contributor Author

in our software after updating ruby to 3.3.5 there is warning that require to add the ostruct gem as an explicit dependency

warning example:

warning: .../ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of net-ldap-0.19.0 to request adding ostruct into its gemspec.

Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HarlemSquirrel HarlemSquirrel merged commit 450b543 into ruby-ldap:master Oct 29, 2024
7 checks passed
@Ivanov-Anton Ivanov-Anton deleted the #431-improvement branch October 29, 2024 05:26
@Ivanov-Anton
Copy link
Contributor Author

@HarlemSquirrel Thanks, waiting a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to Add ostruct as a Dependency in net-ldap
2 participants