-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psych 5.1.1 fails to load on JRuby 9.x #655
Comments
The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main). This change pins the version back to 5.1.0 until ruby/psych#655 is sorted.
The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main). This change pins the version back to 5.1.0 until ruby/psych#655 is sorted. (cherry picked from commit 401d166)
The new psych 5.1.1 gem seems to not work when installed in JRuby 9.4 (used in main). This change pins the version back to 5.1.0 until ruby/psych#655 is sorted. (cherry picked from commit 401d166) Co-authored-by: João Duarte <[email protected]>
@headius sorry for the ping here, just wanted to raise awareness of the impact of the changes between 5.1.0 and 5.1.1. |
It looks like 5.1.1 was released to fix an issue on JRuby in 5.1.0, but that the Java artifacts were not rebuilt.
(This occurred to me because I remembered it happening before: #598) |
@dometto Oh interesting! This makes some sense; if the Java bits were not updated, then they are not referencing the new path to the properties file. That would explain why my stepping through the code was off by several lines; it was the wrong code! @hsbt I think we need a new release that includes updated JRuby bits. They did not get rebuilt for 5.1.1 so they are broken in that release. Rebuilding them requires JRuby 9.4.1.0. I updated CI to use 9.4.1.0 for testing until we can fully drop support for the older Region API in Joni. |
@hsbt Perhaps we can also chat about how to make this easier in the future, perhaps with a CI job to cleanly build all the gem targets every push. |
**What problem is this PR intended to solve?** drop minitest-reporters, because even having it in the Gemfile messes with minitest-parallel_fork, sigh. For context, see: - minitest-reporters/minitest-reporters#247 - jeremyevans/minitest-parallel_fork#3 Also, avoid psych 5.1.1 because of ruby/psych#655
@headius I built psych-5.1.1 with JRuby 9.4.3.0. Should I rebuild it with JRuby 9.4.1.0? I'm not sure what's the problem of this case. |
@hsbt Perhaps you were not on master HEAD? Looking at comments above, PsychParser.java did not change between the two releases. I am confused as well. |
I'm also not sure why they are same. I'll release 5.1.1.1 with this:
|
@hsbt @jsvd @dometto @olleolleolle The new gem appears to work correctly! Please verify! |
Confirmed that I could run my test suite, and release https://rubygems.org/gems/gemstash/versions/2.7.1-java with it. Thanks! |
A recent release of Psych was not compatible with JRuby. You can learn more about the issue here: ruby/psych#655
ruby/psych#655 has been fixed with the release of 5.1.1.1
ruby/psych#655 has been fixed with the release of 5.1.1.1
ruby/psych#655 has been fixed with the release of 5.1.1.1 (cherry picked from commit 6046402)
ruby/psych#655 has been fixed with the release of 5.1.1.1 (cherry picked from commit 6046402) Co-authored-by: João Duarte <[email protected]>
I think ruby/psych#655 was resolved long ago
* Allow custom Redis instance for tests You probably don't want the tests to use the same Redis you use for any app development. Maybe you want to use Docker with custom port: docker run --rm -it -p 16379:6379 redis:6 * Run sentry-resque specs without Rails Tests and fixes #2243 * Run with latest `psych` I think ruby/psych#655 was resolved long ago * Note `constantize` sentry-resque fix in CHANGELOG
[EDIT] the issue also happens with 9.3.11.0 and the latest daily snapshot of 9.4.4.0
The new psych gem version 5.1.1 doesn't work correctly when installed in JRuby
, I've tried only with 9.4.2.0 so far:The text was updated successfully, but these errors were encountered: