Skip to content

Commit

Permalink
dep: drop minitest-reporters, avoid psych 5.1.1 (#3002)
Browse files Browse the repository at this point in the history
**What problem is this PR intended to solve?**

drop minitest-reporters, because even having it in the Gemfile messes
with
minitest-parallel_fork, sigh.

For context, see:

- minitest-reporters/minitest-reporters#247
- jeremyevans/minitest-parallel_fork#3

Also, avoid psych 5.1.1 because of
ruby/psych#655
  • Loading branch information
flavorjones authored Oct 15, 2023
2 parents 672c162 + 59e4981 commit 1db5446
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 10 deletions.
3 changes: 2 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ group :development do
# tests
gem "minitest", "5.20.0"
gem "minitest-parallel_fork", "1.3.1"
gem "minitest-reporters", "1.6.1"
gem "ruby_memcheck", "2.2.0"
gem "rubyzip", "~> 2.3.2"
gem "simplecov", "= 0.21.2"
Expand All @@ -44,3 +43,5 @@ end
group :rdoc do
gem "rdoc", "6.5.0"
end

gem "psych", "!= 5.1.1", "!= 5.1.0" # https://github.com/ruby/psych/issues/655
3 changes: 0 additions & 3 deletions scripts/test-gem-file-contents
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ require "bundler/inline"
gemfile do
source "https://rubygems.org"
gem "minitest"
gem "minitest-reporters"
end

require "yaml"
Expand Down Expand Up @@ -66,8 +65,6 @@ if ARGV.include?("-v")
end

require "minitest/autorun"
require "minitest/reporters"
Minitest::Reporters.use!([Minitest::Reporters::SpecReporter.new])

puts "Testing '#{gemfile}' (#{gemspec.platform})"
describe File.basename(gemfile) do
Expand Down
3 changes: 0 additions & 3 deletions scripts/test-gem-installation
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ require "bundler/inline"
gemfile do
source "https://rubygems.org"
gem "minitest"
gem "minitest-reporters"
gem "nokogiri"
end

Expand All @@ -39,8 +38,6 @@ if ARGV.include?("-v")
end

require "minitest/autorun"
require "minitest/reporters"
Minitest::Reporters.use!([Minitest::Reporters::SpecReporter.new])

puts "Testing #{gemspec.full_name} installed in #{gemspec.base_dir}"
describe gemspec.full_name do
Expand Down
3 changes: 0 additions & 3 deletions scripts/test-nokogumbo-compatibility
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ require "bundler/inline"
gemfile(true) do
source "https://rubygems.org"
gem "minitest"
gem "minitest-reporters"
gem "nokogiri", "=#{gemspec.version}"
if nokogumbo_version
gem "nokogumbo", "=#{nokogumbo_version}"
Expand All @@ -68,8 +67,6 @@ if ARGV.include?("-v")
end

require "minitest/autorun"
require "minitest/reporters"
Minitest::Reporters.use!([Minitest::Reporters::SpecReporter.new])

puts "Testing #{gemspec.full_name} installed in #{gemspec.base_dir}"
describe gemspec.full_name do
Expand Down

0 comments on commit 1db5446

Please sign in to comment.