-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Handle undefined from JSON.stringify (#321)
mini_racer uses V8's JSON.stringify to serialize results but it returns undefined instead of a string for certain inputs, like WASM string refs. When that undefined value is then passed to Ruby's JSON parser, it raises an exception (using rb_raise) that longjmps out of a lexical scope where we hold the v8::Locker, without properly unlocking it again. Fixes: #320
- Loading branch information
1 parent
8c13559
commit e713b65
Showing
2 changed files
with
19 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters