Handle undefined from JSON.stringify #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini_racer uses V8's JSON.stringify to serialize results but it returns undefined instead of a string for certain inputs, like WASM string refs. When that undefined value is then passed to Ruby's JSON parser, it raises an exception (using rb_raise) that longjmps out of a lexical scope where we hold the v8::Locker, without properly unlocking it again. Fixes: rubyjs#320
bnoordhuis
force-pushed
the
json-stringify
branch
from
dcb70d9
to
8ca9159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mini_racer uses V8's JSON.stringify to serialize results but it returns undefined instead of a string for certain inputs, like WASM string refs.
When that undefined value is then passed to Ruby's JSON parser, it raises an exception (using rb_raise) that longjmps out of a lexical scope where we hold the v8::Locker, without properly unlocking it again.
Fixes: #320