Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out fetching resources output from terraform commands #1320

Closed
wants to merge 3 commits into from

Conversation

levkk
Copy link

@levkk levkk commented Dec 20, 2020

Attempt at fixing #1306

Might not be the right place for this logic; first time committer, please let me know if there is a better place to do this

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #1320 (8e17fac) into master (d09e798) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
+ Coverage   70.05%   70.09%   +0.04%     
==========================================
  Files          74       74              
  Lines        5540     5548       +8     
==========================================
+ Hits         3881     3889       +8     
  Misses       1303     1303              
  Partials      356      356              
Impacted Files Coverage Δ
server/events/terraform/terraform_client.go 78.89% <100.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09e798...8e17fac. Read the comment docs.

@levkk levkk marked this pull request as ready for review December 20, 2020 18:42
@acastle
Copy link
Contributor

acastle commented Dec 21, 2020

Hi @levkk, thank you for the contribution!

There is a lot of interest in changing the message formatting behavior at the moment, in particular the following PRs:
#1315
#1309

Unfortunately, either of these approaches will dramatically change how this particular feature should be implemented. It feels like the best course of action would be to hold off on making additional changes to this particular area for the time being. At least until there is a clear direction on a more flexible way of handling the outputs from terraform.

@levkk
Copy link
Author

levkk commented Dec 22, 2020

@acastle Hello! Sounds good, thank you. Happy to rewrite this when the dust settles.

@levkk levkk closed this Dec 22, 2020
@lkysow
Copy link
Member

lkysow commented Jan 13, 2021

I think we could put this logic into https://github.com/runatlantis/atlantis/blob/master/server/events/runtime/plan_step_runner.go#L231. This handles the old format of refreshing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants