fix(output): Remove Refreshing state... from output

[mathcantin]

Fixes #1306

Since Terraform 0.14.0 there are no separator between refreshing plan and the plan. This strategy is to find the last line with "Refreshing state..." and remove it with all of the above.

I remove the sentence "Refreshing Terraform state in-memory prior to plan..." from tests because Terraform don't show that anymore.

[mathcantin]

I update the PR to check if Terraform is in version >= 0.14.0.

[mathcantin]

@lkysow Do you have time to check this?

[bryantbiggs]

this would be greatly appreciated - we upgraded to TF 0.14.x to get the concise diffs but now we have a wall of Terraform refresh text output 🙏🏼

[Ninir]

@chenrui333 Hi! would it be possible to get your eyes on it? we'd love to help in any way, and appreciate any time you might spend on this. Thank you!

[mathcantin]

@nishkrishnan Could you check this?

[nishkrishnan]

Generally looks good, I see that you've been submitting a bunch of PRs around 0.14.0 improvements and thanks for your contribution. But in these cases where there are lot of if and elses being done to preserve backwards compatibility I'd suggest something along the lines of using composition to abstract the underlying implementation and wrapping them up in a nicely packaged interface so we can proxy to implementations based on a condition. Will make things more readable and easy to add changes for future versions.

[chenrui333]

👍 lgtm

[Ninir]

Thanks @chenrui333 and @nishkrishnan, definitely appreciate it! 🙇

[nishkrishnan]

you're gonna need to update test fixtures and then I can merge it back in

[mathcantin]

you're gonna need to update test fixtures and then I can merge it back in

What?

[nishkrishnan]

The tests failed on master so I'm reverting the merge.

[mathcantin]

I'm sorry, that the line 101, my editor remove the last space automatically. I fix that.

[mathcantin]

I'm reopen a new PR?