Remove refreshing state 3e

[mathcantin]

Following #1432

[bryantbiggs]

👀 3rd times a charm?!

[nishkrishnan]

👀 3rd times a charm?!

lol It still didn't trigger the check. really sorry for the inconvenience, I'm not entirely familiar with the circleci integration. Can you try just adding like a whitespace commit?

[mathcantin]

Yes, it's done since the second PR. On local UTs ans validation pass.

[bryantbiggs]

@nishkrishnan / @mathcantin - I've opened #1436 to validate the changes here (no additional changes, just getting the tests kicked off) and it looks like the tests are failing

[codecov]

Codecov Report

Merging #1433 (86cba2f) into master (b635309) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   69.52%   69.58%   +0.05%     
==========================================
  Files          93       93              
  Lines        6327     6332       +5     
==========================================
+ Hits         4399     4406       +7     
+ Misses       1550     1549       -1     
+ Partials      378      377       -1     

Impacted Files	Coverage Δ
server/events/runtime/apply_step_runner.go	86.17% <100.00%> (+1.79%)	⬆️
server/events/runtime/plan_step_runner.go	85.24% <100.00%> (+0.89%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b635309...86cba2f. Read the comment docs.

[mathcantin]

@bryantbiggs @nishkrishnan Integration UTs wasn't up-to-date with master, I update it. But these on workspace-parallel-yaml won't work in master, I fix it.

Checks are green!

[nishkrishnan]

@bryantbiggs @nishkrishnan Integration UTs wasn't up-to-date with master, I update it. But these on workspace-parallel-yaml won't work in master, I fix it.

Checks are green!

I'm unclear why you needed to update the workspace-parallel files since tests were all passing on master initially.

[nishkrishnan]

this file contains staging in the name meaning that the output should only contain staging in it. Something is wrong here since it's attempting to apply both production and staging. The fixtures were correct as is.

[Ninir]

@mathcantin is there anything we can do to help? thanks for leading the charge on this so far!

[mathcantin]

I don't know what I'm supposed to do.

• All tests need to pass
• I must don't edit tests
• But THE FUCKING TEST DON'T PASS ON MASTER

[bryantbiggs]

I think the tests on master are passing, this dep update PR #1447 is passing (opened automatically yesterday) without issue

[lkysow]

Hi @mathcantin, looks like the tests pass on master (https://app.circleci.com/pipelines/github/runatlantis/atlantis/860/workflows/12b9fbe6-2700-455c-9f55-4367e26a9ea8) so I think we're good. Thanks for the PR and sorry for all the random problems.

I would like to remind you to keep discussion here civil please (i.e. no swearing) and assume everyone is operating in good faith.

[witsch]

Any chance of getting this out as a 0.16.2 release perhaps? 🙂 (or is there any ETA for a final 0.17.0?)

[dimisjim]

@witsch You can pick this up by pulling the latest tagged runatlantis docker image.

I am using it for the past few weeks and it works fine