Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update github.com/cactus/go-statsd-client/statsd digest to 1cec395 in go.mod #2813

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 19, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/cactus/go-statsd-client/statsd require digest 94959e3 -> 1cec395

Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner December 19, 2022 00:22
@renovate renovate bot added the dependencies PRs that update a dependency file label Dec 19, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Dec 19, 2022

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: docker run --rm --name=renovate_sidecar --label=renovate_child -v "/mnt/renovate/gh/runatlantis/atlantis":"/mnt/renovate/gh/runatlantis/atlantis" -v "/tmp/renovate-cache":"/tmp/renovate-cache" -v "/tmp/containerbase":"/tmp/containerbase" -e GOPATH -e GOPROXY -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w "/mnt/renovate/gh/runatlantis/atlantis" docker.io/renovate/sidecar bash -l -c "install-tool golang 1.19.5 && go get -d -t ./... && go mod tidy && go mod tidy"
go: errors parsing go.mod:
/mnt/renovate/gh/runatlantis/atlantis/go.mod:65:2: require github.com/cactus/go-statsd-client/statsd: version "v0.0.0-20220206212030-1cec3953a711" invalid: missing github.com/cactus/go-statsd-client/statsd/go.mod at revision 1cec3953a711

@nitrocode
Copy link
Member

nitrocode commented Dec 19, 2022

@krrrr38 this only updated the go.mod but not go.sum... odd

@nitrocode nitrocode closed this Dec 19, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Dec 19, 2022

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the github.com/cactus/go-statsd-client/statsd 1cec395 update again.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/github.com-cactus-go-statsd-client-statsd-digest branch December 19, 2022 00:33
@nitrocode nitrocode restored the renovate/github.com-cactus-go-statsd-client-statsd-digest branch December 19, 2022 02:56
@nitrocode nitrocode reopened this Dec 19, 2022
@renovate renovate bot force-pushed the renovate/github.com-cactus-go-statsd-client-statsd-digest branch 2 times, most recently from 10283b7 to 44f6afb Compare December 19, 2022 03:36
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have issues even after a rebase

@krrrr38
Copy link
Contributor

krrrr38 commented Dec 19, 2022

uber/tally depends on too old go-statsd-client which doesn't have go.mod... https://github.com/cactus/go-statsd-client/tree/94959e3146b2b5d8cd5dad4ed2d4cf0883185cae

@krrrr38
Copy link
Contributor

krrrr38 commented Dec 19, 2022

uber-go/tally requires cactus/go-statsd-client struct by public api, so this is not become indirect dependency.

There are following candidates.

  • Fix uber-go/tally to use cactus/go-statsd-client/v5 then update all dependencies
  • Replace uber-go/tally
  • This dependency is almost indirect dependency. so close or keep this PR and ignore it.

@renovate renovate bot changed the title fix(deps): update github.com/cactus/go-statsd-client/statsd digest to 1cec395 fix(deps): update github.com/cactus/go-statsd-client/statsd digest to 1cec395 in go.mod Jan 15, 2023
@renovate renovate bot force-pushed the renovate/github.com-cactus-go-statsd-client-statsd-digest branch from 44f6afb to 6e0bd5c Compare January 17, 2023 17:39
@nitrocode nitrocode closed this Feb 8, 2023
@renovate renovate bot deleted the renovate/github.com-cactus-go-statsd-client-statsd-digest branch February 8, 2023 13:03
@nitrocode nitrocode mentioned this pull request May 2, 2023
21 tasks
@nitrocode
Copy link
Member

nitrocode commented May 2, 2023

Now that @krrrr38 (thanks again!) change has been merged in upstream, they released 4.1.7 so if we upgrade to 4.x then we should no longer experience this issue

uber-go/tally#194

https://github.com/uber-go/tally/releases/tag/v4.1.7

@nitrocode nitrocode mentioned this pull request Jun 8, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update a dependency file do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants