Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump tally to v4 #3498

Merged
merged 1 commit into from
Jun 9, 2023
Merged

chore(deps): bump tally to v4 #3498

merged 1 commit into from
Jun 9, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 8, 2023 •
edited
Loading

what

  • chore(deps): bump tally to v4
sed 's,"github.com/uber-go/tally,tally "github.com/uber-go/tally/v4,g' -i **/*.go
go get -u

why

  • latest dependencies

tests

  • I have tested my changes by ensuring tests pass

references

@nitrocode nitrocode requested a review from a team as a code owner June 8, 2023 03:25
@github-actions github-actions bot added dependencies PRs that update a dependency file go Pull requests that update Go code labels Jun 8, 2023
@nitrocode
Copy link
Member Author

cc: @krrrr38 (et al) in case you have a second to review

krrrr38
krrrr38 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@krrrr38 krrrr38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

go.sum
github.com/twmb/murmur3 v1.1.6 h1:mqrRot1BRxm+Yct+vavLMou2/iJt0tNVTTC0QoIjaZg=
github.com/twmb/murmur3 v1.1.6/go.mod h1:Qq/R7NUyOfr65zD+6Q5IHKsJLwP7exErjN6lyyq3OSQ=
github.com/uber-go/tally v3.5.3+incompatible h1:88A6MgEioo4+VvzpJDFw3wa2G6+88oKLSq2+Q1Twieg=
github.com/uber-go/tally v3.5.3+incompatible/go.mod h1:YDTIBxdXyOU/sCWilKB4bgyufu1cEi0jdVnRdxvjnmU=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@nitrocode nitrocode enabled auto-merge (squash) June 8, 2023 12:48
@nitrocode
Copy link
Member Author

Thank you for reviewing. Also tagging recent stats contributors @inkel and @albertorm95

inkel
inkel approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW looks good to me.

@nitrocode
Copy link
Member Author

cc: @jamengual @chenrui333 @GenPage please review

@GenPage
Copy link
Member

GenPage commented Jun 9, 2023

LGTM

@nitrocode nitrocode merged commit 7950018 into runatlantis:main Jun 9, 2023
@nitrocode nitrocode added this to the v0.24.3 milestone Jun 11, 2023
@nitrocode nitrocode deleted the tally-v4 branch June 13, 2023 03:15
@nitrocode nitrocode mentioned this pull request Jun 14, 2023
Open
mtavaresmedeiros pushed a commit to mtavaresmedeiros/atlantis that referenced this pull request Jul 3, 2023
@nitrocode
chore(deps): bump tally to v4 (runatlantis#3498)
c47faec
@nitrocode nitrocode mentioned this pull request Sep 7, 2023
Closed
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
chore(deps): bump tally to v4 (runatlantis#3498)
028f262
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
chore(deps): bump tally to v4 (runatlantis#3498)
632ea75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inkel inkel inkel approved these changes

@krrrr38 krrrr38 krrrr38 approved these changes

@GenPage GenPage GenPage approved these changes

Assignees
No one assigned
Labels
dependencies PRs that update a dependency file go Pull requests that update Go code
Projects
None yet
Milestone
v0.24.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nitrocode @GenPage @inkel @krrrr38