feat(reaction): disable reactions by setting an empty string #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusramberg
changed the title
marcusramberg
force-pushed
the
marcus/check_nick
branch
from
73c155c
to
3ff1395
Compare
GenPage
previously approved these changes
May 1, 2023
nitrocode
reviewed
May 4, 2023
…b, and only worked for 'atlantis' command. This commit improves on that to make it possible to implement reactions in other VCS providers and also reuse the existing comment parsing.
marcusramberg
force-pushed
the
marcus/check_nick
branch
from
621db39
to
41310bf
Compare
nitrocode
reviewed
May 5, 2023
nitrocode
approved these changes
May 5, 2023
nitrocode
changed the title
|
Were you also able to test in your setup with the reaction and without? |
I tested the previous version, and it only added reactions for 'atlantis' and not @botnick, that's what motivated this PR. Here's it looks in our sandbox now:
|
|
Thanks @marcusramberg ! We really appreciate your PRs. Looking forward to the next release! For now, please use the |
|
this is pretty cool thanks @marcusramberg again!!! |
mtavaresmedeiros
pushed a commit
to mtavaresmedeiros/atlantis
that referenced
this pull request
Jul 3, 2023
…ntis#3360) * fix: Previous implementation tried to do comment parsing inside github, and only worked for 'atlantis' command. This commit improves on that to make it possible to implement reactions in other VCS providers and also reuse the existing comment parsing. * test: Add negative test to confirm reactions are not added for invalid comments * test: Add a negative test to confirm invalid commands do not get a reaction
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…ntis#3360) * fix: Previous implementation tried to do comment parsing inside github, and only worked for 'atlantis' command. This commit improves on that to make it possible to implement reactions in other VCS providers and also reuse the existing comment parsing. * test: Add negative test to confirm reactions are not added for invalid comments * test: Add a negative test to confirm invalid commands do not get a reaction
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…ntis#3360) * fix: Previous implementation tried to do comment parsing inside github, and only worked for 'atlantis' command. This commit improves on that to make it possible to implement reactions in other VCS providers and also reuse the existing comment parsing. * test: Add negative test to confirm reactions are not added for invalid comments * test: Add a negative test to confirm invalid commands do not get a reaction
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves on that to make it possible to implement reactions in other VCS providers and also reuse the existing comment parsing.
what
My initial implementation of the reactions have a couple of problems:
@bot-nick applywhy
This PR attempts to remedy the above problems by passing the comment ID to handleCommentEvent and doing
the reaction from there. The test written for the functionality continues to pass, indicating that react is
still being called :) I've also added a check to allow disabling reactions by setting them to the empty
string.
Other VCS providers can then be implemented by passing a comment id and implementing ReactToComment
tests
This refactor is tested through the unit test added in previous PR.
references
Initial reaction implementation in #2706