Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reaction): disable reactions by setting an empty string #3360

Merged
merged 3 commits into from
May 6, 2023
Merged

feat(reaction): disable reactions by setting an empty string #3360

merged 3 commits into from
May 6, 2023

Commits on May 5, 2023

  1. fix: Previous implementation tried to do comment parsing inside githu… 

    …b, and only worked for 'atlantis' command.

This commit improves on that to make it possible to implement reactions in other VCS providers and also reuse the existing comment parsing.
    @marcusramberg
    marcusramberg committed May 5, 2023
    Configuration menu
    Copy the full SHA
    fb21d75 View commit details
    Browse the repository at this point in the history

  2. test: Add negative test to confirm reactions are not added for invali… 

    …d comments
    @marcusramberg
    marcusramberg committed May 5, 2023
    Configuration menu
    Copy the full SHA
    41ead1b View commit details
    Browse the repository at this point in the history

  3. test: Add a negative test to confirm invalid commands do not get a re… 

    …action
    @marcusramberg
    marcusramberg committed May 5, 2023
    Configuration menu
    Copy the full SHA
    41310bf View commit details
    Browse the repository at this point in the history