feat: Log error on cleanup in e2e #4834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
|
Oops, this has to be on the upstream branch to work, closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Log error that comes from
cleanup()function in e2e tests.why
Since the cleanup function is deferred, we swallow the error and there's no way for the end user to know that it occurred.
I decided against trying to return this error from the main function, or even something like a log.Fatal, since it's just for cleanup, so stopping earlier isn't going to help anyone.
tests
After this PR goes up I will make sure the github e2e runs correctly, then introduce an intentional error in cleanup and make sure that's logged as expected.
references
Found while working on #4582