Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Log error on cleanup in e2e #4834

Closed
wants to merge 1 commit into from
Closed

feat: Log error on cleanup in e2e #4834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion e2e/e2e.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,12 @@ func (t *E2ETester) Start(ctx context.Context) (*E2EResult, error) {
log.Printf("created pull request %s", url)

// defer closing pull request and delete remote branch
defer cleanUp(ctx, t, pullId, branchName) // nolint: errcheck
defer func() {
err := cleanUp(ctx, t, pullId, branchName)
if err != nil {
log.Printf("Failed to cleanup: %v", err)
}
}()

// wait for atlantis to respond to webhook and autoplan.
time.Sleep(2 * time.Second)
Expand Down
Loading