Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permutations unnecessarily complex 1 #748

Conversation

phimuemue
Copy link
Member

A first step for #747 that clarifies why the panic won't happen.

This simply moves code around so that the subsequent diff is simpler.
This at least makes clear why the panic! in Permutations::next cannot happen.
@phimuemue phimuemue added this pull request to the merge queue Sep 6, 2023
Merged via the queue into rust-itertools:master with commit 93730e1 Sep 6, 2023
8 checks passed
@phimuemue phimuemue deleted the permutations_unnecessarily_complex_1 branch September 6, 2023 20:55
@jswrenn jswrenn mentioned this pull request Nov 14, 2023
@jswrenn jswrenn added this to the next milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants