Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permutations unnecessarily complex 1 #748

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Permutations unnecessarily complex 1 #748

merged 2 commits into from
Sep 6, 2023

Commits on Sep 6, 2023

  1. Simplify Permutations (1.1) move impl Permutations 

    This simply moves code around so that the subsequent diff is simpler.
    @phimuemue
    phimuemue committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    2618cd3 View commit details
    Browse the repository at this point in the history

  2. Simplify Permutations (1.2) inline Permutations::advance 

    This at least makes clear why the panic! in Permutations::next cannot happen.
    @phimuemue
    phimuemue committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    21608b5 View commit details
    Browse the repository at this point in the history