Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create typename for raw pointers #439

Closed
nikomatsakis opened this issue May 5, 2020 · 1 comment · Fixed by #442
Closed

create typename for raw pointers #439

nikomatsakis opened this issue May 5, 2020 · 1 comment · Fixed by #442
Assignees
Labels
current-sprint Being worked on in the current sprint good first issue A good issue to start working on Chalk with

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented May 5, 2020

As part of #368, we need to extend chalk's TypeName to model the built-in *const and *mut types. We can add a variant Raw(Mutability), where Mutability is the same type described in #438.

You can follow #394 which provides a rough model of what needs to be extended. You probably want to model this on how tuples are handled, a N-ary tuple like (_, _) has two generic type parameters, and raw pointers have one generic type parameter.

You would need to

  • add Raw(Mutability) to TypeName
  • extend parser to accept *const, *mut types
  • Update the current state table to include the new types, I don't think it requires any special handling apart from Sized, I think its impls live in the standard library

This issue has been assigned to @nathanwhit via this comment.

@nikomatsakis nikomatsakis added current-sprint Being worked on in the current sprint good first issue A good issue to start working on Chalk with labels May 5, 2020
@nathanwhit
Copy link
Member

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current-sprint Being worked on in the current sprint good first issue A good issue to start working on Chalk with
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants