Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw pointers to TypeName #442

Merged
merged 9 commits into from
May 7, 2020

Conversation

nathanwhit
Copy link
Member

Closes #439.

I'm a bit unsure about a few changes here, namely the lowering and the duplication of the Mutability enum in both the ast module and in chalk-ir, which feels a bit messy.

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one nit

chalk-parse/src/ast.rs Show resolved Hide resolved
book/src/clauses/well_known_traits.md Outdated Show resolved Hide resolved
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackh726 jackh726 merged commit 220953b into rust-lang:master May 7, 2020
@nathanwhit nathanwhit deleted the typename-raw-pointer branch May 25, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create typename for raw pointers
2 participants