Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[let_with_type_underscore]: Don't emit on locals from procedural macros #10865

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 1, 2023

closes #10498

changelog: [let_with_type_underscore]: Don't emit on locals from procedural macros

@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 1, 2023
@flip1995 flip1995 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 2, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Jun 7, 2023

Thank you. @bors r+

@bors
Copy link
Collaborator

bors commented Jun 7, 2023

📌 Commit ba1fb74 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 7, 2023

⌛ Testing commit ba1fb74 with merge f729147...

@bors
Copy link
Collaborator

bors commented Jun 7, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing f729147 to master...

@bors bors merged commit f729147 into rust-lang:master Jun 7, 2023
@Centri3 Centri3 deleted the let_with_type_underscore_tracing branch June 9, 2023 21:07
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 6, 2023
@flip1995
Copy link
Member

flip1995 commented Jul 6, 2023

rust-lang/rust#113417

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2023
…ishearth

[beta] Clippy beta backport

Backported PRs:

- rust-lang/rust-clippy#10813
- rust-lang/rust-clippy#10865
- rust-lang/rust-clippy#10873
- rust-lang/rust-clippy#10992

Those address bugs, that were either introduced with 1.71 and that we would like to address before they get into stable or bugs that were introduced in 1.70 and that we would like to be fixed in 1.71 already.

Detailed arguments for the backports of those PRs are in the PRs (mostly).

r? `@Mark-Simulacrum`
@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let_with_type_underscore false positive with '_ lifetime and tracing::instrument
6 participants