items_after_test_module: Ignore in-proc-macros items
#10992
Conversation
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
|
I'm unfamiliar with Rust's release process, so I thought I'd ask: is there any chance this will land in 1.71 before that's stable (or a point release, not sure whether those exist)? If not, I'm worried that workarounds like https://github.com/martinvonz/jj/pull/1686/files will be necessary until the MSRV for a project is at 1.72 or above. Also, thank you very much for fixing this! |
It is currently on track to be a part of Rust 1.72 as long as it gets synced to rust-lang/rust before July 7 (very likely). I'm open to this being uplifted, it needs to be uplifted into beta before July 13 to make 1.71. |
|
I've started this zulip discussion to check if the clippy team is open to it being uplifted. If so, we can talk to the release team and send them a patch. |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
flip1995
added
the
beta-nominated
flip1995
added
beta-accepted
…ishearth [beta] Clippy beta backport Backported PRs: - rust-lang/rust-clippy#10813 - rust-lang/rust-clippy#10865 - rust-lang/rust-clippy#10873 - rust-lang/rust-clippy#10992 Those address bugs, that were either introduced with 1.71 and that we would like to address before they get into stable or bugs that were introduced in 1.70 and that we would like to be fixed in 1.71 already. Detailed arguments for the backports of those PRs are in the PRs (mostly). r? `@Mark-Simulacrum`
xFrednet
removed
the
beta-accepted
This is new in 1.71, but seems to get confused by the test_case macro. It was supposedly fixed in rust-lang/rust-clippy#10992 but that seems to not have entirely worked. Signed-off-by: James Bornholt <[email protected]>
This is new in 1.71, but seems to get confused by the test_case macro. It was supposedly fixed in rust-lang/rust-clippy#10992 but that seems to not have entirely worked. Signed-off-by: James Bornholt <[email protected]>
|
I'm still getting false positives for this lint with the latest It's being triggered by a derive macro that generates a test module. The code is here, although you'll need to remove my workaround to get the lint to fire again. The workaround: change |
|
Can you open a new issue with possibly a minimal reproducer for this, please? |
The library
test-caseis having some problems with this lint, ignoring proc macros should fix it.Related to #10713 and frondeus/test-case#122
(Couldn't add test cases for this exact situation without importing the library, but I think the fix is simple enough that we can be pretty sure there won't be any problems :) )
changelog:[
items_after_test_module]: Ignore items in procedural macros