Fix unnecessary_to_owned
false positive
#9424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9351.
Note that this commit reworks that fix for #9317. The change
is to check that the type implements
AsRef<str>
before regardingto_string
as an equivalent ofto_owned
. This was suggestedby Jarcho in the #9317 issue comments.
The benefit of this is that it moves some complexity out of
check_other_call_arg
and simplifies the module as a whole.changelog: FP: [
unnecessary_to_owned
]: No longer lints, if type change would cause errors in the caller function