Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary_to_owned false positive #9424

Merged
merged 1 commit into from Sep 4, 2022
Merged

Fix unnecessary_to_owned false positive #9424

merged 1 commit into from Sep 4, 2022

Commits on Sep 3, 2022

  1. Fix unnecessary_to_owned false positive 

    Fixes #9351.

Note that this commit reworks that fix for #9317. The change
is to check that the type implements `AsRef<str>` before regarding
`to_string` as an equivalent of `to_owned`. This was suggested
by Jarcho in the #9317 issue comments.

The benefit of this is that it moves some complexity out of
`check_other_call_arg` and simplifies the module as a whole.
    Michael Wright committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    750a2d5 View commit details
    Browse the repository at this point in the history