Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential typo in suggestion of E0689 #114683

Closed
sunmy2019 opened this issue Aug 10, 2023 · 3 comments · Fixed by #114732
Closed

Potential typo in suggestion of E0689 #114683

sunmy2019 opened this issue Aug 10, 2023 · 3 comments · Fixed by #114732
Assignees
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@sunmy2019
Copy link

sunmy2019 commented Aug 10, 2023

This line looks like a typo to me, should it be f64?

Originally posted by @sunmy2019 in #94963 (comment)

Currently, it affects line 1684.

|| found_assoc(tcx.types.i64)
|| found_assoc(tcx.types.i128)
|| found_assoc(tcx.types.u8)
|| found_assoc(tcx.types.u16)
|| found_assoc(tcx.types.u32)
|| found_assoc(tcx.types.u64)
|| found_assoc(tcx.types.u128)
|| found_assoc(tcx.types.f32)
|| found_assoc(tcx.types.f32);
if found_candidate
&& actual.is_numeric()

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 10, 2023
@compiler-errors
Copy link
Member

Yeah, this could be fixed.

@compiler-errors compiler-errors added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 10, 2023
@compiler-errors
Copy link
Member

Ideally a test should also be crafted that shows that this missing f64 affects an error message or something.

@gurry
Copy link
Contributor

gurry commented Aug 10, 2023

@rustbot claim

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 11, 2023
Fix typo in suggest.rs where f32 was used instead of f64

Fixes rust-lang#114683
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 12, 2023
Fix typo in suggest.rs where f32 was used instead of f64

Fixes rust-lang#114683
@bors bors closed this as completed in bd54536 Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants