Fix typo in suggest.rs where f32 was used instead of f64

[gurry]

Fixes #114683

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @b-naber (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=gurry
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_f5c6d0f7-d7a6-453f-9c45-31470dd9fde6
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=c24f28a19e712194f0b3bb9bb2800307f07eaf9a
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_f5c6d0f7-d7a6-453f-9c45-31470dd9fde6
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_f5c6d0f7-d7a6-453f-9c45-31470dd9fde6
GITHUB_TRIGGERING_ACTOR=gurry
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/114732/merge
GITHUB_WORKFLOW_SHA=c24f28a19e712194f0b3bb9bb2800307f07eaf9a
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_18_X64=/opt/hostedtoolcache/go/1.18.10/x64
---
#7 16.08 done.
#7 DONE 16.9s

#8 [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
#8 354.9 xz: (stdin): Unexpected end of input
#8 354.9 tar: Unexpected EOF in archive
#8 354.9 tar: Unexpected EOF in archive
#8 354.9 tar: Error is not recoverable: exiting now
#8 ERROR: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
 > [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ:
 > [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ:
354.9 xz: (stdin): Unexpected end of input
354.9 tar: Unexpected EOF in archive
354.9 tar: Unexpected EOF in archive
------
Dockerfile:24
--------------------
  22 |       && rm -rf /var/lib/apt/lists/*
  22 |       && rm -rf /var/lib/apt/lists/*
  23 |     
  24 | >>> RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
  25 |     ENV PATH="/node-v16.9.0-linux-x64/bin:${PATH}"
  26 |     ENV RUST_CONFIGURE_ARGS="--set rust.validate-mir-opts=3"
--------------------
ERROR: failed to solve: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
#0 building with "default" instance using docker driver

#1 [internal] load .dockerignore
#1 transferring context: 2B done
---
#8 [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
#8 0.442 xz: (stdin): File format not recognized
#8 0.442 tar: Child returned status 1
#8 0.442 tar: Error is not recoverable: exiting now
#8 ERROR: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
 > [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ:
0.442 xz: (stdin): File format not recognized
0.442 tar: Child returned status 1
0.442 tar: Error is not recoverable: exiting now
---
  24 | >>> RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
  25 |     ENV PATH="/node-v16.9.0-linux-x64/bin:${PATH}"
  26 |     ENV RUST_CONFIGURE_ARGS="--set rust.validate-mir-opts=3"
--------------------
ERROR: failed to solve: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
#0 building with "default" instance using docker driver

#1 [internal] load .dockerignore
#1 transferring context: 2B done
---
#7 [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
#7 0.377 xz: (stdin): File format not recognized
#7 0.377 tar: Child returned status 1
#7 0.377 tar: Error is not recoverable: exiting now
#7 ERROR: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
 > [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ:
0.377 xz: (stdin): File format not recognized
0.377 tar: Child returned status 1
0.377 tar: Error is not recoverable: exiting now
---
  24 | >>> RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
  25 |     ENV PATH="/node-v16.9.0-linux-x64/bin:${PATH}"
  26 |     ENV RUST_CONFIGURE_ARGS="--set rust.validate-mir-opts=3"
--------------------
ERROR: failed to solve: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
#0 building with "default" instance using docker driver

#1 [internal] load .dockerignore
#1 transferring context: 2B done
---
#7 [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
#7 0.395 xz: (stdin): File format not recognized
#7 0.395 tar: Child returned status 1
#7 0.395 tar: Error is not recoverable: exiting now
#7 ERROR: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
 > [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ:
0.395 xz: (stdin): File format not recognized
0.395 tar: Child returned status 1
0.395 tar: Error is not recoverable: exiting now
---
  24 | >>> RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
  25 |     ENV PATH="/node-v16.9.0-linux-x64/bin:${PATH}"
  26 |     ENV RUST_CONFIGURE_ARGS="--set rust.validate-mir-opts=3"
--------------------
ERROR: failed to solve: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
#0 building with "default" instance using docker driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 2.64kB done
---
#7 [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
#7 1.052 xz: (stdin): File format not recognized
#7 1.052 tar: Child returned status 1
#7 1.052 tar: Error is not recoverable: exiting now
#7 ERROR: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
 > [ 3/10] RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ:
1.052 xz: (stdin): File format not recognized
1.052 tar: Child returned status 1
1.052 tar: Error is not recoverable: exiting now
---
  24 | >>> RUN curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ
  25 |     ENV PATH="/node-v16.9.0-linux-x64/bin:${PATH}"
  26 |     ENV RUST_CONFIGURE_ARGS="--set rust.validate-mir-opts=3"
--------------------
ERROR: failed to solve: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2
##[error]Process completed with exit code 1.
Post job cleanup.

[gurry]

@compiler-errors I could not come up with a test that would reproduce the impact of this typo unfortunately. It will have an impact only if found_assoc(tcx.types.f32) returns something different from found_assoc(tcx.types.f64). As per my understanding both of them will always return the same value since f32 and f64 have the exact same inherent methods and implement the same traits.

I did try by implementing a custom trait of my own for f64 which isn't implemented for f32, but in that case the compiler was able to unambiguously resolve the method and hence no compiler error occurred :(.

Please suggest a test I can add.

[gurry]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Someone please help me resolve this. The error looks related to the build system itself:

ERROR: process "/bin/sh -c curl -sL https://nodejs.org/dist/v16.9.0/node-v16.9.0-linux-x64.tar.xz | tar -xJ" did not complete successfully: exit code: 2

Perhaps retrying the job is enough?

[klensy]

Just force push your branch to retry.

[compiler-errors]

Yeah, I guess this doesn't need a test. @gurry has a good point above about unambiguously resolving because there are only two float kinds.

[compiler-errors]

@bors r+ rollup

(whatever, this pr doesnt need ci)

[bors]

📌 Commit e903752 has been approved by compiler-errors

It is now in the queue for this repository.

[klensy]

This isn't merged, btw

[gurry]

Why didn't it get merged @klensy? It says above that I "closed this X hours ago", but I didn't do anything.

[gurry]

Ah, I did delete the branch in my repo. That was stupid. Let me try to reopen if I can.

[gurry]

r? @compiler-errors

[rustbot]

Could not assign reviewer from: compiler-errors.
User(s) compiler-errors are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

[gurry]

@rustbot review

[bors]

⌛ Testing commit e903752 with merge bd54536...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing bd54536 to master...

[rust-timer]

Finished benchmarking commit (bd54536): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-3.2%, -2.0%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.837s -> 632.779s (-0.17%)