Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cargo.toml in getting-started doc #32928

Closed
deepak opened this issue Apr 13, 2016 · 3 comments · Fixed by #32931
Closed

Update Cargo.toml in getting-started doc #32928

deepak opened this issue Apr 13, 2016 · 3 comments · Fixed by #32931

Comments

@deepak
Copy link
Contributor

deepak commented Apr 13, 2016

I am learning rust and reading the book for the first time

in https://github.com/rust-lang/rust/blob/9094935b460975b6fac272ebf5985dfd71b90104/src/doc/book/getting-started.md#making-a-new-cargo-project-the-easy-way

the generated Cargo.toml has changed

slight difference is that it has a section called [dependencies]

should we specify the actual file ?
@GuillaumeGomez
Copy link
Member

It should look like the generated Cargo.toml file. Want to open a PR to fix this?

@deepak
Copy link
Contributor Author

deepak commented Apr 13, 2016

@GuillaumeGomez absolutely. on it

@deepak deepak mentioned this issue Apr 13, 2016
Merged
@deepak
Copy link
Contributor Author

deepak commented Apr 13, 2016

@GuillaumeGomez submitted a small PR

Manishearth added a commit to Manishearth/rust that referenced this issue Apr 15, 2016
@Manishearth
Rollup merge of rust-lang#32931 - deepak:gh-issue-32928-update-cargo-…
50932f5 
…in-getting-started-doc, r=GuillaumeGomez

Doc fix: Update Cargo.toml in book/getting-started

The Cargo.toml mentioned in book/getting-started
is missing the section called `[dependencies]`

fixes rust-lang#32928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc fix: Update Cargo.toml in book/getting-started deepak/rust
2 participants
@deepak @GuillaumeGomez