Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc fix: Update Cargo.toml in book/getting-started #32931

Merged
merged 1 commit into from
Apr 16, 2016
Merged

Doc fix: Update Cargo.toml in book/getting-started #32931

merged 1 commit into from
Apr 16, 2016

Conversation

deepak
Copy link
Contributor

@deepak deepak commented Apr 13, 2016

The Cargo.toml mentioned in book/getting-started
is missing the section called [dependencies]

fixes #32928

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez reviewed Apr 13, 2016
View reviewed changes
src/doc/book/getting-started.md
```

Do not worry about the last line, `[dependencies]`, we will come to it later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this sentence a bit awkward. What about "Do not worry about the [dependencies] line, we will come back to it later."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. reads better.
have made the change and rebased

@deepak
Doc fix: Update Cargo.toml in book/getting-started
722faa0 
The Cargo.toml mentioned in book/getting-started
is missing the section called `[dependencies]`
@deepak deepak force-pushed the gh-issue-32928-update-cargo-in-getting-started-doc branch from 0d87443 to 722faa0 Compare April 13, 2016 11:37
@GuillaumeGomez
Copy link
Member

Thanks!

r=me @steveklabnik

@steveklabnik
Copy link
Member

@bors: delegate=@GuillaumeGomez

@bors
Copy link
Contributor

bors commented Apr 13, 2016

✌️ @@GuillaumeGomez can now approve this pull request

@bors
Copy link
Contributor

bors commented Apr 13, 2016

📌 Commit 722faa0 has been approved by guillaumegomez

@steveklabnik
Copy link
Member

whoops

@bors: delegate=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Apr 13, 2016

✌️ @GuillaumeGomez can now approve this pull request

@steveklabnik
Copy link
Member

@bors: r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Apr 13, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Apr 13, 2016

📌 Commit 722faa0 has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit 722faa0 with merge 21161a4...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 14, 2016 at 12:26 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/3790

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#32931 (comment)

@Manishearth Manishearth mentioned this pull request Apr 15, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 15, 2016
@Manishearth
Rollup merge of rust-lang#32931 - deepak:gh-issue-32928-update-cargo-…
50932f5 
…in-getting-started-doc, r=GuillaumeGomez

Doc fix: Update Cargo.toml in book/getting-started

The Cargo.toml mentioned in book/getting-started
is missing the section called `[dependencies]`

fixes rust-lang#32928
bors added a commit that referenced this pull request Apr 15, 2016
@bors
Auto merge of #33005 - Manishearth:rollup, r=Manishearth
576229f 
Rollup of 11 pull requests

- Successful merges: #32923, #32926, #32929, #32931, #32935, #32945, #32946, #32964, #32970, #32973, #32997
- Failed merges:
@bors bors merged commit 722faa0 into rust-lang:master Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Cargo.toml in getting-started doc
6 participants
@deepak @rust-highfive @GuillaumeGomez @steveklabnik @bors @alexcrichton