Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0248 needs to be updated to new format #35391

Closed
sophiajt opened this issue Aug 5, 2016 · 3 comments
Closed

E0248 needs to be updated to new format #35391

sophiajt opened this issue Aug 5, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

From: src/test/compile-fail/E0248.rs

Error E0248 needs a span_label, updating it from:

error[E0248]: found value `Foo::Bar` used as a type
  --> src/test/compile-fail/E0248.rs:15:20
   |
15 | fn do_something(x: Foo::Bar) { } //~ ERROR E0248
   |                    ^^^^^^^^

To:

error[E0248]: found value `Foo::Bar` used as a type
  --> src/test/compile-fail/E0248.rs:15:20
   |
15 | fn do_something(x: Foo::Bar) { } //~ ERROR E0248
   |                    ^^^^^^^^ value used as a type
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 5, 2016
@shyamsundarb-arch
Copy link
Contributor

shyamsundarb-arch commented Aug 6, 2016

I am new here. I too want to contribute. If you can give me a hint as to what has to be done for this ticket. It would help me to address other similar issues. Thanks in advance.

Update:
I have made the changes and have posted. I referred E0055.

shyamsundarb-arch added a commit to shyamsundarb-arch/rust that referenced this issue Aug 6, 2016
@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 6, 2016

@shyaamsundhar - I've updated the list so that you have this issue (E0248)

@shyamsundarb-arch
Copy link
Contributor

@jonathandturner Thanks

shyamsundarb-arch added a commit to shyamsundarb-arch/rust that referenced this issue Aug 7, 2016
shyamsundarb-arch added a commit to shyamsundarb-arch/rust that referenced this issue Aug 7, 2016
shyamsundarb-arch added a commit to shyamsundarb-arch/rust that referenced this issue Aug 7, 2016
Fixed the error Build rust-lang#38327

Address issue number: rust-lang#35391

Update E0248.rs
shyamsundarb-arch added a commit to shyamsundarb-arch/rust that referenced this issue Aug 7, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 13, 2016
…turner

E0248, E0267 & E0268 Change into issue format

r? @jonathandturner  Part of rust-lang#35391, rust-lang#35519 and rust-lang#35520. I have squashed all changes into a single commit. Please review the changes.

E0248 Change in issue format

E0267 UT New Format

E0268 UT New Format

E0267 & E0268 New Error Format
eddyb added a commit to eddyb/rust that referenced this issue Aug 14, 2016
…turner

E0248, E0267 & E0268 Change into issue format

r? @jonathandturner  Part of rust-lang#35391, rust-lang#35519 and rust-lang#35520. I have squashed all changes into a single commit. Please review the changes.

E0248 Change in issue format

E0267 UT New Format

E0268 UT New Format

E0267 & E0268 New Error Format
eddyb added a commit to eddyb/rust that referenced this issue Aug 14, 2016
…turner

E0248, E0267 & E0268 Change into issue format

r? @jonathandturner  Part of rust-lang#35391, rust-lang#35519 and rust-lang#35520. I have squashed all changes into a single commit. Please review the changes.

E0248 Change in issue format

E0267 UT New Format

E0268 UT New Format

E0267 & E0268 New Error Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants