Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0267 needs to be updated to new format #35519

Closed
sophiajt opened this issue Aug 8, 2016 · 3 comments
Closed

E0267 needs to be updated to new format #35519

sophiajt opened this issue Aug 8, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

From: src/test/compile-fail/E0267.rs

E0267 needs a span_label, updating it from:

error[E0267]: `break` inside of a closure
  --> src/test/compile-fail/E0267.rs:12:18
   |
12 |     let w = || { break; }; //~ ERROR E0267
   |                  ^^^^^

To:

error[E0267]: `break` inside of a closure
  --> src/test/compile-fail/E0267.rs:12:18
   |
12 |     let w = || { break; }; //~ ERROR E0267
   |                  ^^^^^ cannot break inside of a closure
@shyamsundarb-arch
Copy link
Contributor

I will take this.

@shyamsundarb-arch
Copy link
Contributor

A small doubt E0267 and E0268 has changes in the same file ("src\librustc_passes\loops.rs")...
Can I give a single commit to solve both these tickets?

@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 9, 2016

Yes, please group them into one PR.

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 13, 2016
…turner

E0248, E0267 & E0268 Change into issue format

r? @jonathandturner  Part of rust-lang#35391, rust-lang#35519 and rust-lang#35520. I have squashed all changes into a single commit. Please review the changes.

E0248 Change in issue format

E0267 UT New Format

E0268 UT New Format

E0267 & E0268 New Error Format
eddyb added a commit to eddyb/rust that referenced this issue Aug 14, 2016
…turner

E0248, E0267 & E0268 Change into issue format

r? @jonathandturner  Part of rust-lang#35391, rust-lang#35519 and rust-lang#35520. I have squashed all changes into a single commit. Please review the changes.

E0248 Change in issue format

E0267 UT New Format

E0268 UT New Format

E0267 & E0268 New Error Format
eddyb added a commit to eddyb/rust that referenced this issue Aug 14, 2016
…turner

E0248, E0267 & E0268 Change into issue format

r? @jonathandturner  Part of rust-lang#35391, rust-lang#35519 and rust-lang#35520. I have squashed all changes into a single commit. Please review the changes.

E0248 Change in issue format

E0267 UT New Format

E0268 UT New Format

E0267 & E0268 New Error Format
@bstrie bstrie added the A-diagnostics Area: Messages for errors, warnings, and lints label Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Development

No branches or pull requests

3 participants