Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable compiler warnings in stage0 #9754

Closed
alexcrichton opened this issue Oct 8, 2013 · 1 comment · Fixed by #9891
Closed

Enable compiler warnings in stage0 #9754

alexcrichton opened this issue Oct 8, 2013 · 1 comment · Fixed by #9891
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@alexcrichton
Copy link
Member

It's been awhile since we had any regressions in lint, and I've started to really hurt by having all lints allow-by-default in stage0 only to catch the bugs 15 minutes later during stage2.

It'd be awesome if we could allow warnings in stage0 by default now. If there's a bug with lint we'd have to wait till the next snapshot for the bug to go away, but we'd still be guaranteed no lints in stage1+
@alexcrichton alexcrichton mentioned this issue Oct 16, 2013
Merged
@bors bors closed this as completed in 88acb73 Oct 17, 2013
@pnkfelix
Copy link
Member

In case anyone else is curious, it is not too hard to override choices like this from the make invocation itself, without editing any of the makefiles themselves (changes that you would have to remember to revert before commiting/merging/etc), in order to select the old -Awarnings in stage 0 and thus quiet down the builds (which have been noisy in recent days due to the deprecated_owned_vector warning that is unrecognized in stage0).

The way I do it is:

make -j8 --environment-overrides WFLAGS_ST0=-Awarnings

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12281 - lnicola:increase-overflow-depth, r=ln…
65a213c 
…icola

Increase defalt chalk overflow depth to match max solver size

TBC:

 - rust-lang#12279: ok above 480
 - ~~rust-lang#12182~~
 - ~~rust-lang#12095~~
 - rust-lang#11902: ok above 350
 - ~~rust-lang#11668~~
 - rust-lang#11370: ok above 450
 - rust-lang#9754: probably ok above 250 (!), and the code in cause and branch are gone

Closes rust-lang#12279
Closes rust-lang#11902
Closes rust-lang#11370
Closes rust-lang#9754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow stage0 warnings alexcrichton/rust
2 participants
@alexcrichton @pnkfelix