Change fmt! to format! #11668
Closed
Change fmt! to format! #11668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1975,7 +1975,7 @@ Supported traits for `deriving` are: | |||
| * `Default`, to create an empty instance of a data type. | |||
| * `Zero`, to create an zero instance of a numeric data type. | |||
| * `ToStr`, to convert to a string. For a type with this instance, | |||
| `obj.to_str()` has similar output as `fmt!("%?", obj)`, but it differs in that | |||
| `obj.to_str()` has similar output as `format!("%?", obj)`, but it differs in that | |||
There was a problem hiding this comment.
format!("{:?}", obj), rather. This is only true of deriving. I think the whole sentence should be removed.
There was a problem hiding this comment.
(especially since ToStr is deprecated in favor of fmt::Default)
|
Could you rebase these into one commit? Also feel free to comment on the pull request because sadly no one gets any updates on a force push! |
|
Closed by #11988 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…icola Increase defalt chalk overflow depth to match max solver size TBC: - rust-lang#12279: ok above 480 - ~~rust-lang#12182~~ - ~~rust-lang#12095~~ - rust-lang#11902: ok above 350 - ~~rust-lang#11668~~ - rust-lang#11370: ok above 450 - rust-lang#9754: probably ok above 250 (!), and the code in cause and branch are gone Closes rust-lang#12279 Closes rust-lang#11902 Closes rust-lang#11370 Closes rust-lang#9754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt! is now deprecated, use format! instead